Switch SplicePrototype feature flag to the prod feature bit
#4387
+13
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @wpaulino as a reviewer! |
Contributor
|
@TheBlueMatt this needs a rebase |
When we shipped 0.2 we used the feature bit 155 to signal splicing, in line with what eclair was using. However, eclair was actually using that bit to signal splicing on a previous design which is incompatible with the current spec. The result of this was that eclair nodes may attempt to splice using their protocol and we'd fail to deserialize their splice message (resulting in a reconnect, which luckily would clear their splice attempt and return the connection to normal). As we really need to get off of their feature bit and there's not much reason to keep using a non-final-spec bit, we simply redefine `SplicePrototype` to bit 63 here.
Now that `SplicePrototype` and `SpliceProduction` share the same feature bit, there's not really any reason to have the `SplicePrototype` feature at all. Instead, we drop it, leaving only a `Splice` feature.
TheBlueMatt
force-pushed
the
2026-02-stop-squatting-features
branch
from
2992536 to
5427b0d
Compare
Collaborator
Author
|
Oops sorry I did this on 0.2, pushed against main. |
wpaulino
approved these changes
Feb 5, 2026
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
jkczyz
approved these changes
Feb 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4387 +/- ##
=======================================
Coverage 86.00% 86.01%
=======================================
Files 156 156
Lines 102857 102834 -23
Branches 102857 102834 -23
=======================================
- Hits 88465 88455 -10
+ Misses 11883 11871 -12
+ Partials 2509 2508 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Backported to 0.2 in #4389 |
f3r10
pushed a commit
to moneydevkit/rust-lightning
that referenced
this pull request
Feb 9, 2026
Cherry-picked from lightningdevkit#4387 (98c3cff) This fixes Eclair compatibility issues where Eclair uses bit 155 for an incompatible previous splice design, causing deserialization failures. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to backport the first commit to 0.2 to fix current compat issues.